Repository navigation
feat(helpscout): add Help Scout integration with OAuth and app credentials, selectors, and webhook triggers - #9252
Conversation
…tials, selectors, and webhook triggers
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Parameter Secret Detection — all current findings are reported as inline comments on this PR. See the check run for the overall status. |
[Medium impact] The latest changes appear safe to merge, with no new actionable issues found. SummaryAdds Help Scout with 25 tools, OAuth and app credentials, inbox and user selectors, and 13 webhook triggers.
|
There was a problem hiding this comment.
All reported issues were addressed across 84 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…nd address review findings
|
@greptile |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 86 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@greptile |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
credentialKind: 'any'): browser OAuth (authorization code, refresh-token rotation,HELPSCOUT_CLIENT_ID/HELPSCOUT_CLIENT_SECRET) and a customer-owned app saved as a client-credentials service account (helpscout-service-account, no deployment OAuth requirement); connect verifies the acting user via/v2/users/meselectors.executepath (page-number cursor from_links.next, detail lookups)X-HelpScout-Signatureverification, event matching onX-HelpScout-Event, and an event+signature idempotency key since Help Scout sends no delivery IDhelpscout-errorsextractor surfaces field-level_embedded.errorswithout the rejected valueType of Change
Testing
lib/webhooks/providers/helpscout.test.ts(15): Help Scout's published signature vector accepted; tampered body, wrong secret, missing header, missing secret rejected; event matching;formatInputkeys equal declared trigger outputs. Verified red by switching the HMAC to SHA-256transformResponse, the minter, selectors, error extractor, webhook handler, and block param mapping against Help Scout's documented request/response examplescheck-block-registryvs staging,check:canvas-sentences --block=helpscout,check:docs,check:integration-catalog,check:deployment-config,check:tool-request-boundary,check:tool-param-reachability,check:bare-icons,check:fork-dependent-coverage,check:client-boundary,check:file-names,check:source-conventions,check:utils,check:comment-hygiene, biome on changed filescheck:audits, and test suite left to CIChecklist
test-auditauthoring gate)