fix(desktop): harden update and quit flows - #7395
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR hardens desktop release publication, update selection, restart and quit behavior, native permissions, window restoration, and shared renderer update state.
Confidence Score: 5/5The PR appears safe to merge. The previously reported release-fallback failure is fixed: invalid same-channel candidates are rejected individually, manifest and installer validation remains release-scoped, and selection continues to an older valid candidate; no blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/desktop/update-feed.ts | Iterates same-channel releases in version order and accepts only candidates whose manifest and installer pass shared validation. |
| apps/sim/app/api/desktop/update/latest-mac.yml/route.ts | Uses candidate-level validation so an invalid newest release no longer prevents fallback to an older valid update. |
| apps/sim/app/api/desktop/update/download/route.ts | Uses the same validated release selection as the updater feed before redirecting to an installer. |
| .github/workflows/desktop-release.yml | Enforces signing before publication and validates artifact integrity, bundle identity, hardened runtime, and notarization. |
| apps/desktop/src/main/updater.ts | Hardens update readiness, installer URL validation, and restart behavior. |
| apps/sim/hooks/use-desktop-update-state.ts | Centralizes race-safe desktop update state for the gate, settings, and sidebar consumers. |
Reviews (4): Last reviewed commit: "fix(desktop): classify invalid release f..." | Re-trigger Greptile
There was a problem hiding this comment.
All reported issues were addressed across 27 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
e6ea8a1 to
47cd071
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 27 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 27 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
Type of Change
Testing
Checklist