fix(workflow): preserve canvas and deploy modal behavior - #7392
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThis PR preserves the temporary connection picker while it is dragged and keeps deploy-output selection interactive within its modal.
Confidence Score: 5/5The PR appears safe to merge, with no concrete correctness or security failures identified in the changed paths. The transient canvas node is handled before the new early return, existing combobox callers retain portalled rendering by default, and the deploy modal explicitly opts into the intended inline behavior.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx | Correctly handles transient connection-picker position changes before bypassing persisted workflow-node reconciliation and uses matching initial dimensions. |
| packages/emcn/src/components/combobox/combobox.tsx | Adds an opt-in portal override while preserving the existing portalled behavior by default. |
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/chat/components/output-select/output-select.tsx | Threads the optional portal behavior through both output-select trigger variants without changing existing callers. |
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/components/chat/chat.tsx | Enables inline output dropdown rendering specifically within the deploy modal. |
| packages/emcn/src/components/chip-modal/chip-modal.tsx | Suppresses horizontal body overflow while retaining vertical scrolling. |
Reviews (1): Last reviewed commit: "fix(workflow): preserve canvas and deplo..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
bun run lint,bun run check:audits, focused Vitest suites, and affected package typechecks passChecklist