Skip to content

fix(workflow): preserve canvas and deploy modal behavior - #7392

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/dependency-audit-final-audit
Sep 2, 2026
Merged

fix(workflow): preserve canvas and deploy modal behavior#7392
waleedlatif1 merged 1 commit into
stagingfrom
codex/dependency-audit-final-audit

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • preserve the temporary connection edge while dragging the new-block picker
  • keep deploy output selection interactive inside the modal and prevent horizontal body overflow
  • cover the shared combobox and modal behavior with regression tests

Type of Change

  • Bug fix

Testing

  • Tested canvas picker dragging, deploy output selection, and modal overflow manually
  • bun run lint, bun run check:audits, focused Vitest suites, and affected package typechecks pass

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 2, 2026 7:45am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR preserves the temporary connection picker while it is dragged and keeps deploy-output selection interactive within its modal.

  • Separates transient selector-node changes from persisted workflow-node processing and initializes the selector with explicit dimensions.
  • Adds optional inline rendering for shared combobox dropdowns and enables it for deploy output selection.
  • Prevents incidental horizontal overflow in modal bodies.
  • Adds regression coverage for prop forwarding, inline dropdown placement, and modal overflow classes.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete correctness or security failures identified in the changed paths.

The transient canvas node is handled before the new early return, existing combobox callers retain portalled rendering by default, and the deploy modal explicitly opts into the intended inline behavior.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx Correctly handles transient connection-picker position changes before bypassing persisted workflow-node reconciliation and uses matching initial dimensions.
packages/emcn/src/components/combobox/combobox.tsx Adds an opt-in portal override while preserving the existing portalled behavior by default.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/chat/components/output-select/output-select.tsx Threads the optional portal behavior through both output-select trigger variants without changing existing callers.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/components/chat/chat.tsx Enables inline output dropdown rendering specifically within the deploy modal.
packages/emcn/src/components/chip-modal/chip-modal.tsx Suppresses horizontal body overflow while retaining vertical scrolling.

Reviews (1): Last reviewed commit: "fix(workflow): preserve canvas and deplo..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 3a51850 into staging Sep 2, 2026
29 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/dependency-audit-final-audit branch September 2, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant