Skip to content

fix(agent): move advanced MCP option to bottom - #7389

Merged
TheodoreSpeaks merged 6 commits into
stagingfrom
fix/chat-deploy
Sep 2, 2026
Merged

fix(agent): move advanced MCP option to bottom#7389
TheodoreSpeaks merged 6 commits into
stagingfrom
fix/chat-deploy

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • move MCP Server (Advanced) out of the top action group
  • place it in a dedicated Advanced section after the standard tool and workflow sections

Testing

  • focused ToolInput suites: 54 tests passed
  • Biome check passed
  • typecheck left to GitHub CI as requested

@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 2, 2026 8:49am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR restores output-picker interactions and improves access to selected nested outputs while reorganizing the advanced MCP action.

  • Normalizes selected output values and pins selected outputs in a dedicated group for quick deselection.
  • Adds option-level selection handling shared by the small and medium picker variants.
  • Moves “MCP Server (Advanced)” into a final Advanced section without changing its availability guards.
  • Expands focused tests for nested selection, selection preservation, deselection, and the medium picker.

Confidence Score: 5/5

The PR appears safe to merge, with the restored picker behavior and MCP menu reorganization preserving the relevant selection and availability contracts.

The output options now use the real Combobox selection path consistently across picker sizes, selected nested outputs remain directly removable, existing selections are preserved, and the relocated MCP action retains its previous conditions and behavior.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/chat/components/output-select/output-select.tsx Adds explicit toggle callbacks, value normalization, selected-option pinning, and consistent behavior across Combobox variants; no actionable defect found.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/chat/components/output-select/output-select.test.tsx Updates the component mocks and adds focused coverage for nested selections, preservation, deselection, and medium-size interactions.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsx Relocates the advanced MCP action into a bottom Advanced group while preserving its permission, support, preview, disabled, and unsupported guards.

Reviews (1): Last reviewed commit: "fix(chat-deploy): restore output picker ..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@TheodoreSpeaks TheodoreSpeaks changed the title fix(chat-deploy): restore output picker interactions fix(agent): move advanced MCP option to bottom Sep 2, 2026
@TheodoreSpeaks
TheodoreSpeaks merged commit 54bd538 into staging Sep 2, 2026
28 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the fix/chat-deploy branch September 2, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant