fix(agent): move advanced MCP option to bottom - #7389
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThis PR restores output-picker interactions and improves access to selected nested outputs while reorganizing the advanced MCP action.
Confidence Score: 5/5The PR appears safe to merge, with the restored picker behavior and MCP menu reorganization preserving the relevant selection and availability contracts. The output options now use the real Combobox selection path consistently across picker sizes, selected nested outputs remain directly removable, existing selections are preserved, and the relocated MCP action retains its previous conditions and behavior.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/chat/components/output-select/output-select.tsx | Adds explicit toggle callbacks, value normalization, selected-option pinning, and consistent behavior across Combobox variants; no actionable defect found. |
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/chat/components/output-select/output-select.test.tsx | Updates the component mocks and adds focused coverage for nested selections, preservation, deselection, and medium-size interactions. |
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsx | Relocates the advanced MCP action into a bottom Advanced group while preserving its permission, support, preview, disabled, and unsupported guards. |
Reviews (1): Last reviewed commit: "fix(chat-deploy): restore output picker ..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing