fix(workflows): preserve cancellation scope assertions - #7368
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThe PR restores parent-scope assertions on internal and v2 workflow cancellation and binds Copilot cancellation to its trusted workspace.
Confidence Score: 5/5The PR appears safe to merge, with cancellation assertions consistently failing closed on workflow or workspace mismatches. The changed adapters preserve trusted parent scope while cancellation continues to resolve canonical execution ownership and authorize the resulting workflow context before performing the operation.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/workflows/application/cancel-run.ts | Extends cancellation input with optional workflow and workspace assertions and forwards them to canonical run-context resolution. |
| apps/sim/app/api/v2/workflows/[workflowId]/runs/[runId]/cancel/route.ts | Preserves the workflow path parameter as an assertion when cancelling a v2 run. |
| apps/sim/app/api/workflows/[id]/executions/[executionId]/cancel/route.ts | Preserves the internal route’s workflow parent as an assertion while retaining request cancellation propagation. |
| apps/sim/lib/copilot/tools/handlers/workflow/mutations.ts | Constrains execution-ID-only Copilot cancellation to the trusted workspace in its execution context. |
| apps/sim/lib/workflows/application/context.test.ts | Adds coverage for canonical execution resolution and concealed workspace mismatches. |
Reviews (1): Last reviewed commit: "fix(workflows): preserve cancellation sc..." | Re-trigger Greptile
There was a problem hiding this comment.
No issues found across 9 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.
Re-trigger cubic
Summary
Type of Change
Testing
Checklist