fix(selectors): expose incomplete loaded catalogs - #7338
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThe PR exposes a sanitized catalog-truncation signal and carries it through selector loading, workflow search/replace, and comparison resolution.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported comparison test-harness mismatch is fixed and the regression test now exercises the incomplete-catalog path.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/selectors/client/execute-selector.ts | Replaces the bare-array catalog result with an item collection and explicit truncation state across provider, page-cap, and option-budget boundaries. |
| apps/sim/lib/selectors/server/sanitize.ts | Projects provider truncation diagnostics into a safe boolean without exposing diagnostic details. |
| apps/sim/hooks/queries/workflow-search-replace.ts | Propagates incomplete-catalog state through selector detail and replacement queries while preserving available matches. |
| apps/sim/lib/workflows/comparison/resolve-values.ts | Preserves unresolved raw selector IDs when catalog truncation makes absence inconclusive. |
| apps/sim/lib/workflows/comparison/format-description.test.ts | Correctly updates the loader test double, enables selector hydration, and covers truncated catalog misses. |
Reviews (2): Last reviewed commit: "fix(selectors): cover incomplete compari..." | Re-trigger Greptile
Contributor
There was a problem hiding this comment.
No issues found across 9 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.
Re-trigger cubic
waleedlatif1
force-pushed
the
fix/selector-load-all-truncation
branch
from
September 1, 2026 23:46
32b2d46 to
f1a065c
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
truncatedboolean on selector list responses while keeping provider diagnostic details server-only{ items, truncated }from the non-mounted selector catalog loader and distinguish provider, page-cap, and option-budget truncation from complete catalogsThe old 50-page behavior was partially resolved before this PR: staging now allows 200 pages and 10,000 unique options. The residual issue is that
loadAllSelectorOptionsstill returned a bare array when either limit stopped collection, and the unified selector route stripped provider truncation diagnostics entirely.Provider truncation was an inherited limitation. PR #7185 raised the page cap, added deduplication and the 10,000-option budget, but retained the bare-array interface and added another silent early-return path at the option budget. This PR fixes that shared signal without changing limits, provider adapters, mounted selectors, or UI copy.
Type of Change
Testing
Passed locally:
bun run --cwd apps/sim lint:checkbun run check:api-validation:strictbun run check:fork-dependent-coveragebun run check:client-boundarybun run check:react-querygit diff --checkbun run --cwd apps/sim type-checkreaches three pre-existing errors in files unchanged fromorigin/staging:sub-block.tsx:workflow-output-selectoris not comparable toSubBlockTypeblocks/icon-color.ts:perceivedBackgroundBrightnessis not exported by@sim/utils/colortriggers/slack/oauth.ts:workflow-output-selectoris not assignable toSubBlockTypeNo live provider account is required. Deterministic mocked responses cover a complete 10,000-option catalog and a 200-page walk with a remaining cursor.
Checklist
Screenshots/Videos
Not included. This is a shared contract/consumer correctness change with no UI changes.