fix(workflows): authorize paused execution reads - #7303
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThe PR routes paused-execution reads through the shared workflow authorization boundary and updates the resume surface to fetch protected details client-side.
Confidence Score: 5/5The PR appears safe to merge, with paused-execution detail consistently protected at the page, API, application, and data-lookup boundaries. Authorization completes before protected detail loading, execution lookup is constrained by both workflow and execution identifiers, and client failure states avoid rendering inaccessible cached details.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/workflows/application/read-paused-workflow-execution.ts | Adds an authorized read use case whose manager lookup remains bound to the canonical workflow and requested execution. |
| apps/sim/app/api/resume/[workflowId]/[executionId]/route.ts | Migrates the resume-detail endpoint to the shared authenticated route boundary with concealed authorization errors and no-store responses. |
| apps/sim/app/api/workflows/[id]/paused/[executionId]/route.ts | Applies the same authorized paused-execution read behavior to the sibling workflow endpoint. |
| apps/sim/app/(interfaces)/resume/[workflowId]/[executionId]/page.tsx | Requires a valid session and workflow-read authorization before rendering the client resume surface. |
| apps/sim/app/(interfaces)/resume/[workflowId]/[executionId]/resume-page-client.tsx | Moves protected detail loading client-side, validates deep-linked contexts, and distinguishes authentication, concealment, and retryable failures. |
| apps/sim/hooks/queries/resume-execution.ts | Removes server-provided initial detail and adds bounded retry behavior that treats authorization and not-found responses as terminal. |
| apps/sim/lib/workflows/application/operations.ts | Registers paused-execution detail as a workspace-scoped workflow read operation. |
Sequence Diagram
sequenceDiagram
participant U as User
participant P as Resume page
participant R as Detail API
participant A as Workflow authorization
participant M as Pause manager
U->>P: Open resume deep link
P->>A: Authorize session for workflow
alt Unauthorized or workflow unavailable
A-->>P: Forbidden or not found
P-->>U: Concealed unavailable state
else Authorized
A-->>P: Allowed
P-->>U: Render client surface
U->>R: Fetch paused execution detail
R->>A: Authorize workflow read
A-->>R: Authorized workflow context
R->>M: Load by workflowId and executionId
M-->>R: Protected execution detail
R-->>U: Private, no-store response
end
Reviews (1): Last reviewed commit: "fix(workflows): authorize paused executi..." | Re-trigger Greptile
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
bun run lintbun run check:audits(39 audits)bunx turbo run type-check --filter=@sim/app --filter=@sim/authbun run test:actorless-executor-operationsbun run check:api-validation:strictChecklist