Skip to content

Reject live mode for table workflow tools - #7301

Closed
icecrasher321 wants to merge 1 commit into
stagingfrom
codex/table-workflow-live-mode-guard
Closed

Reject live mode for table workflow tools#7301
icecrasher321 wants to merge 1 commit into
stagingfrom
codex/table-workflow-live-mode-guard

Conversation

@icecrasher321

Copy link
Copy Markdown
Collaborator

Summary

  • Reject legacy deploymentMode live calls for add_workflow_group and update_workflow_group at the Copilot table-tool boundary.
  • Return an actionable error explaining that table workflow groups use the latest active deployment.
  • Keep the public table HTTP contracts unchanged.

This closes the rolling-version case where an older Mothership could request draft semantics and Sim would silently report success while actually using deployed state.

Companion Mothership PR: https://github.com/simstudioai/mothership/pull/466

Tests

  • bunx biome check on the changed files
  • bun run --cwd apps/sim test for user-table and table-split suites: 68 tests
  • bun run --cwd apps/sim type-check
  • git diff --check

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 31, 2026 8:24pm

Request Review

@greptile-apps

greptile-apps Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR rejects legacy deploymentMode: "live" requests for Copilot table workflow-group creation and updates, preventing callers from receiving success after their requested semantics are silently changed.

  • Adds an early, actionable rejection before workflow resolution or mutation.
  • Adds parameterized coverage for both add_workflow_group and update_workflow_group.
  • Leaves the public table HTTP contracts unchanged.

Confidence Score: 5/5

The PR appears safe to merge, with the intended legacy live-mode requests rejected before any workflow resolution or table mutation.

The new condition matches the documented legacy payload, returns an actionable failure, and tests both affected workflow-group operations while confirming mutation is not invoked.

Important Files Changed

Filename Overview
apps/sim/lib/copilot/tools/server/table/user-table.ts Adds a narrowly scoped pre-mutation guard for legacy live-mode workflow-group requests; no actionable defect identified.
apps/sim/lib/copilot/tools/server/table/user-table.test.ts Replaces silent-stripping coverage with explicit rejection assertions for both affected operations and verifies no resolution or creation occurs.

Reviews (1): Last reviewed commit: "fix(copilot): reject live table workflow..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@icecrasher321

Copy link
Copy Markdown
Collaborator Author

Closing per rollout decision: Mothership will deploy alongside Sim, so we do not need special handling for stale deploymentMode calls.

@icecrasher321
icecrasher321 deleted the codex/table-workflow-live-mode-guard branch August 31, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant