fix(rate-limiter): hosted-key queue follow-up fixes#4762
fix(rate-limiter): hosted-key queue follow-up fixes#4762TheodoreSpeaks wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Hosted-key queue: Each head heartbeat refresh now also re-extends the Redis queue list TTL (via a pipeline Rate limiter: Workflow columns: When re-driving the next queued group after a cascade lock window, the payload now sets Reviewed by Cursor Bugbot for commit 33c0138. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThis PR applies three targeted follow-up fixes from a prior review of the hosted-key queue implementation. All three address real failure modes in production code paths.
Confidence Score: 5/5All three changes are narrow, well-scoped fixes with corresponding test coverage; no new external dependencies or schema changes are introduced. Each fix targets a specific, well-understood failure mode. The implementations are consistent with the surrounding patterns, tests cover the changed behaviour, and no new failure modes are introduced. No files require special attention; queue.ts and hosted-key-rate-limiter.ts carry the core logic changes and both look correct. Important Files Changed
Reviews (1): Last reviewed commit: "fix(rate-limiter): hosted-key queue foll..." | Re-trigger Greptile |
Summary
interruptibleSleep: re-checksignal.abortedafter registering the listener so an abort firing in the gap still resolves immediately instead of sleeping the full durationenrichmentId: next.enrichmentIdexplicitly when re-driving a workflow group, instead of inheriting a stale value from the prior group via the payload spreadFollow-up to the Greptile review findings on #4756. The Bugbot
cell-render.tsxcomment was intentionally skipped (dismissed as "feature isn't live yet").Type of Change
Testing
Tested manually.
bun run lintclean,bun run check:api-validation:strictpassed, hosted-key tests (43) and workflow-columns tests (5) green.Checklist