Skip to content

improvement(schedules): retries, concurrency limits #4755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 6 commits into from
May 27, 2026
Merged

improvement(schedules): retries, concurrency limits #4755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c1445a6
improvement(schedu
icecrasher321 May 27, 2026
7aa2cc3
improvement(schedules): remove stale generated migration
icecrasher321 May 27, 2026
56631e9
Merge remote-tracking branch 'origin/staging' into improvement/sched-…
icecrasher321 May 27, 2026
d3103b7
address comments
icecrasher321 May 27, 2026
4999666
fix pinned version for lru cache
icecrasher321 May 27, 2026
170951a
retryable errs cleanup
icecrasher321 May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/sim/app/api/environment/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { AuditAction, AuditResourceType, recordAudit } from '@sim/audit'
import { db } from '@sim/db'
import { environment } from '@sim/db/schema'
import { createLogger } from '@sim/logger'
import { toError } from '@sim/utils/errors'
import { generateId } from '@sim/utils/id'
import { eq } from 'drizzle-orm'
import { type NextRequest, NextResponse } from 'next/server'
Expand Down Expand Up @@ -136,8 +137,8 @@ export const GET = withRouteHandler(async (request: Request) => {
>

return NextResponse.json({ data: decryptedVariables }, { status: 200 })
} catch (error: any) {
} catch (error) {
logger.error(`[${requestId}] Environment fetch error`, error)
return NextResponse.json({ error: error.message }, { status: 500 })
return NextResponse.json({ error: toError(error).message }, { status: 500 })
}
})
4 changes: 2 additions & 2 deletions apps/sim/app/api/schedules/[id]/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export const PUT = withRouteHandler(

await db
.update(workflowSchedule)
.set({ status: 'disabled', nextRunAt: null, updatedAt: new Date() })
.set({ status: 'disabled', nextRunAt: null, lastQueuedAt: null, updatedAt: new Date() })
.where(and(eq(workflowSchedule.id, scheduleId), isNull(workflowSchedule.archivedAt)))

logger.info(`[${requestId}] Disabled schedule: ${scheduleId}`)
Expand Down Expand Up @@ -220,7 +220,7 @@ export const PUT = withRouteHandler(

await db
.update(workflowSchedule)
.set({ status: 'active', failedCount: 0, updatedAt: now, nextRunAt })
.set({ status: 'active', failedCount: 0, infraRetryCount: 0, updatedAt: now, nextRunAt })
.where(and(eq(workflowSchedule.id, scheduleId), isNull(workflowSchedule.archivedAt)))

logger.info(`[${requestId}] Reactivated schedule: ${scheduleId}`)
Expand Down
Loading
Loading