Plot datasets against their HDF5 dimension scales - #2035
Open
NAThompson wants to merge 1 commit into
Open
Conversation
NAThompson
force-pushed
the
feat/hdf5-dimension-scales
branch
2 times, most recently
from
August 20, 2026 15:54
786f60f to
b85f997
Compare
Author
|
@axelboc : Force pushed a fix to green up the CI-you'll need to re-approve the run. I believe the e2e might have been victim to drift without my work breaking it? |
H5Web derives plot axes from NeXus metadata only, so a file that labels its axes the native HDF5 way -- `make_scale` plus `attach_scale` -- is plotted against the sample index. A non-uniform abscissa can't be recovered from indices, so such plots are wrong in shape, not merely unlabelled; today the only workaround is to duplicate the data into hand-written `NXdata` groups. Scales are resolved behind a new optional `getDimensionScales` on `DataProviderApi`, implemented here for h5wasm, which can lean on libhdf5 to dereference `DIMENSION_LIST`. Providers that leave it undefined keep plotting against indices, as does any dimension whose scale is missing, non-numeric or the wrong length -- the spec leaves that mismatch to the application. Towards silx-kit#1313.
NAThompson
force-pushed
the
feat/hdf5-dimension-scales
branch
from
September 10, 2026 17:11
b85f997 to
061975d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
H5Web derives plot axes from NeXus metadata only, so a file that labels its
axes the native HDF5 way --
make_scaleplusattach_scale-- is plottedagainst the sample index. A non-uniform abscissa can't be recovered from
indices, so such plots are wrong in shape, not merely unlabelled; today the
only workaround is to duplicate the data into hand-written
NXdatagroups.Scales are resolved behind a new optional
getDimensionScalesonDataProviderApi, implemented here for h5wasm, which can lean on libhdf5 todereference
DIMENSION_LIST. Providers that leave it undefined keep plottingagainst indices, as does any dimension whose scale is missing, non-numeric or
the wrong length -- the spec leaves that mismatch to the application.
Towards #1313.