Restore behavior lost in #158 - #159
Merged
Merged
Conversation
#158 turned several "skip this input" paths into throws or silent drops, and narrowed matchers that were deliberately broad. Dependencies went missing from runs, some updates were reported but never written, and two inputs aborted the run outright. The widest ones: CRLF workflow files yielded zero Docker dependencies, `exclude: ["*"]` (what a Renovate `enabled: false` maps to) stopped matching any name containing a slash, nested npm overrides collapsed onto one key so the wrong entry was written, and a spaced `[workspace . dependencies]` header aborted everything. A pnpm workspace default registry also suppressed a more specific scoped `.npmrc` registry, which sent private package names to the public registry without their token. Two expectations in #158 encoded the regressions rather than the intended behavior, so they are restored with the code. Co-Authored-By: Claude (Opus 5) <noreply@anthropic.com>
The fixture simulates a real package root but omitted `"type": "module"`, so Node 24 and 26 emitted MODULE_TYPELESS_PACKAGE_JSON on stderr and the test's empty-stderr assertion failed. Node 22 does not warn, and a local `--no-warnings` in NODE_OPTIONS hid it outside CI. Co-Authored-By: Claude (Opus 5) <noreply@anthropic.com>
silverwind
added a commit
that referenced
this pull request
Aug 22, 2026
* update deps (silverwind) * Keep hot-path reuse behavior-preserving (silverwind) * Avoid redundant registry and Forge requests (silverwind) * Take Docker Hub tag digests from the listing (silverwind) * Stop a run stalling on rate limits and proxy fallbacks (silverwind) * Restore version bumping for sha-pinned actions (silverwind) * Cut redundant work from dependency lookup hot paths (silverwind) * Restore behavior lost in #158 (#159) (silverwind) * Close correctness gaps against Renovate and cut scope (#158) (silverwind)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes behavior regressions from #158, which turned several "skip this input" paths into throws or silent drops and narrowed matchers that were deliberately broad.
exclude: ["*"], what a Renovateenabled: falsemaps to, stopped matching any name containing/[workspace . dependencies]header aborted the whole rungo.workmembers were dropped, and one CRLF suppressedgo.modupdates.npmrcregistry, sending private names to the public registry untokenizedTwo expectations in #158 encoded the regressions rather than the intended behavior and are restored here.
Written by Claude (Opus 5).