Recover from a blank Home WebView in e2e tests by alex-rawlings-yyc · Pull Request #180 · sillsdev/interlinearizer-extension

alex-rawlings-yyc · 2026-07-28T18:09:49Z

Core fires Home's content retrieval once behind a 20s provider wait and only logs on failure, so losing that race leaves the tab dead for the whole run. Also caps CDP failures and records CI's core revision.

Devin: https://app.devin.ai/review/sillsdev/interlinearizer-extension/pull/180

This change is

Summary by CodeRabbit

Bug Fixes
- Improved E2E reliability by detecting stalled Home views, safely recovering/reopening Home, and verifying project rows are present before continuing.
- Enhanced Home tab handling by closing all Home dock tabs and ensuring no Home tabs remain before re-navigation.
Tests
- Increased E2E polling and suite timeouts to better match CI timing.
- Marked the gloss roundtrip test as slow with a tripled timeout.
- Added run safeguards to stop the CDP suite after the first failure in CI, and included the exact core revision/commit details in workflow summaries.

Core fires Home's content retrieval once behind a 20s provider wait and only logs on failure, so losing that race leaves the tab dead for the whole run. Also caps CDP failures and records CI's core revision.

coderabbitai · 2026-07-28T18:41:11Z

Warning

Review limit reached

@alex-rawlings-yyc, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 28 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ef3cccf2-d9be-4b11-bddc-ac5f2ca4b3ef

📥 Commits

Reviewing files that changed from the base of the PR and between 691d997 and 6682fbe.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (3)

.github/workflows/test.yml
e2e-tests/fixtures/helpers.ts
e2e-tests/playwright-cdp.config.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch e2e-home-webview-recovery

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai · 2026-07-28T18:43:35Z

Warning

Review limit reached

@alex-rawlings-yyc, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d155698a-93fb-424d-9546-c828fde74dec

📥 Commits

Reviewing files that changed from the base of the PR and between 0ecfbbf and 99f7246.

📒 Files selected for processing (1)

e2e-tests/playwright.config.ts

📝 Walkthrough

Walkthrough

The PR improves Home WebView readiness and E2E timeout handling, limits failures in the shared CDP tier, and records the resolved paranext-core commit metadata in test, E2E, lint, and publish workflow summaries.

Changes

E2E reliability

Layer / File(s)	Summary
Home WebView readiness and navigation `e2e-tests/fixtures/helpers.ts`	Project metadata waits now allow longer CI delays; Home rendering is verified and recovered when empty, and all Home tabs are closed after navigation.
E2E timeout and failure policy `e2e-tests/playwright*.config.ts`, `e2e-tests/tests/features/gloss-roundtrip.spec.ts`	The global and gloss-test timeouts increase, while the CDP tier stops after the configured failure limit.

Core revision observability

Layer / File(s)	Summary
Workflow core revision reporting `.github/workflows/*.yml`	Test, E2E, lint, and publish jobs record the resolved `paranext-core` short revision and commit metadata in `GITHUB_STEP_SUMMARY`.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

sillsdev/interlinearizer-extension#151: Overlaps with the E2E helper and Home-tab handling changes.
sillsdev/interlinearizer-extension#169: Introduced related Home and project-metadata readiness work in the same E2E helpers.

Suggested reviewers: imnasnainaec

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding e2e test recovery for a blank Home WebView.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch e2e-home-webview-recovery

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

The 60s metadata gate expired while the sample WEB install was still running, failing a first attempt that was slow rather than broken. The install persists per machine, so waiting it out costs nothing warm.

Core's last-tab auto-reopen passes no existingId and is decided synchronously at close time, so reading the tab count first picks an opener deterministically. Frame lookups now tolerate a duplicate Home.

The chained waits sum to ~265s, so 240_000 could report an opaque test timeout instead of whichever wait actually lost. Also record why the Home row assert must stay on the same .first() locator as the caller.

Both check out paranext-core with no ref, same as test.yml. It matters most in publish: without it a released artifact carries no record of which core revision it was built against.

imnasnainaec

The new comments in e2e-tests/fixtures/helpers.ts feel too verbose, but I don't think that should hold up fixing e2e.

@imnasnainaec reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on alex-rawlings-yyc).

Recover from a blank Home WebView in e2e tests

6682fbe

Core fires Home's content retrieval once behind a 20s provider wait and only logs on failure, so losing that race leaves the tab dead for the whole run. Also caps CDP failures and records CI's core revision.

alex-rawlings-yyc requested a review from imnasnainaec July 28, 2026 18:09

alex-rawlings-yyc self-assigned this Jul 28, 2026

alex-rawlings-yyc linked an issue Jul 28, 2026 that may be closed by this pull request

Fix CI test failures that likely result from recent paranext-core changes #179

Closed

alex-rawlings-yyc added 4 commits July 28, 2026 12:48

Give the cold-runner project install room to finish

2f9e283

The 60s metadata gate expired while the sample WEB install was still running, failing a first attempt that was slow rather than broken. The install persists per machine, so waiting it out costs nothing warm.

Pick one Home reopener instead of racing two

71a42fc

Core's last-tab auto-reopen passes no existingId and is decided synchronously at close time, so reading the tab count first picks an opener deterministically. Frame lookups now tolerate a duplicate Home.

Size the smoke timeout above its worst wait chain

c32455b

The chained waits sum to ~265s, so 240_000 could report an opaque test timeout instead of whichever wait actually lost. Also record why the Home row assert must stay on the same .first() locator as the caller.

Record the core revision in the lint and publish workflows

0ecfbbf

Both check out paranext-core with no ref, same as test.yml. It matters most in publish: without it a released artifact carries no record of which core revision it was built against.

This comment was marked as outdated.

Sign in to view

Fix comment accuracy nit

99f7246

imnasnainaec approved these changes Jul 28, 2026

View reviewed changes

alex-rawlings-yyc merged commit 5a6762c into main Jul 28, 2026
10 checks passed

alex-rawlings-yyc deleted the e2e-home-webview-recovery branch July 28, 2026 19:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Recover from a blank Home WebView in e2e tests - #180

Recover from a blank Home WebView in e2e tests#180
alex-rawlings-yyc merged 6 commits into
mainfrom
e2e-home-webview-recovery

alex-rawlings-yyc commented Jul 28, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 28, 2026

Review limit reached

Uh oh!

coderabbitai Bot commented Jul 28, 2026 •

edited

Loading

Review limit reached

Walkthrough

Changes

Uh oh!

This comment was marked as outdated.

Uh oh!

imnasnainaec left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

alex-rawlings-yyc commented Jul 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 28, 2026

Review limit reached

Uh oh!

coderabbitai Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Uh oh!

This comment was marked as outdated.

Uh oh!

imnasnainaec left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alex-rawlings-yyc commented Jul 28, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 28, 2026 •

edited

Loading