Skip to content

LT-20524: Resolve install directories in silent (/quiet) installs#86

Open
johnml1135 wants to merge 1 commit into
sillsdev:masterfrom
johnml1135:LT-20524
Open

LT-20524: Resolve install directories in silent (/quiet) installs#86
johnml1135 wants to merge 1 commit into
sillsdev:masterfrom
johnml1135:LT-20524

Conversation

@johnml1135

@johnml1135 johnml1135 commented Jun 10, 2026

Copy link
Copy Markdown

Problem

LT-20524 — applications built
on this installer (for example FieldWorks) fail to install in /quiet
mode (PDQ Deploy / PDQ Connect / Intune).

The directory-resolution custom actions (SetDefDataFolder,
VerifyDataPath, and the Use*AppFolder / Use*DataFolder /
Use*HarvestDataFolder set) were scheduled only in the
InstallUISequence. Windows Installer skips that sequence for silent
(/quiet, /qn) and basic-UI (/qb) installs, so APPFOLDER,
DATAFOLDER, and HARVESTDATAFOLDER were never assigned. The
application and its harvested data then installed to the wrong
locations. For FieldWorks, that also broke ICU_DATA resolution and
caused a crash on first use. /passive worked only because it still ran
the reduced-UI sequence.

Fix

Schedule the same directory-resolution actions in the
InstallExecuteSequence, guarded by UILevel < 4 so they run only
when the UI sequence is skipped. Reduced (/passive) and full UI
installs continue to resolve these in the InstallUISequence, so a
user-chosen path is never overridden. VerifyDataPath populates
REGDATAFOLDER (used by the conditions) and always returns Success,
so it is safe in a silent install.

This is the corresponding legacy WiX 3 change for the paired FieldWorks
WiX 6 PR: sillsdev/FieldWorks#937.

Validation

  • WiX authoring is schema-valid (no XML/WiX validation errors).
  • Downstream validation was completed in the paired FieldWorks PR on the
    rebuilt WiX 6 MSI with elevated installs for /quiet, /qb,
    /passive, and full UI. In each successful mode, the app folder,
    data folder, harvested-data folder, and shortcuts resolved correctly.
  • Direct legacy WiX 3 / genericinstaller smoke validation was not
    run in this workspace, so repo-local WiX 3 evidence is still pending.

This change is Reviewable

The directory-resolution custom actions (SetDefDataFolder, VerifyDataPath, and the Use*AppFolder/Use*DataFolder/Use*HarvestDataFolder set) were only scheduled in the InstallUISequence, which Windows Installer skips for silent (/quiet, /qn) and basic-UI (/qb) installs. APPFOLDER, DATAFOLDER, and HARVESTDATAFOLDER were therefore left unset, so the application and its harvested data installed to the wrong locations.

Schedule the same actions in the InstallExecuteSequence, guarded by 'UILevel < 4' so they only run when the UI sequence does not. Reduced (/passive) and full UI installs keep resolving these in the InstallUISequence, so user-chosen paths are not overridden. VerifyDataPath populates REGDATAFOLDER (used by the conditions) and always returns Success, so it is safe in a silent install.
Copilot AI review requested due to automatic review settings June 10, 2026 00:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds directory-resolution custom actions to the InstallExecuteSequence for silent/basic MSI installs, ensuring installation paths (APPFOLDER/DATAFOLDER/HARVESTDATAFOLDER) are set correctly when the UI sequence does not run.

Changes:

  • Schedules directory resolution custom actions under UILevel < 4 in InstallExecuteSequence.
  • Introduces guarded sequencing for default/override/registry-derived folder selection during silent/basic installs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread BaseInstallerBuild/Framework.wxs
Comment thread BaseInstallerBuild/Framework.wxs

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on johnml1135).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants