Conversation
In FwXApp, renamed OnMasterRefresh() to RefreshAllWindows() so that it is not called from the Mediator. Background: Six code paths dispatch the MasterRefresh Mediator message in a mode that does not stop at the first handler (SendMessageToAllNow or BroadcastMessage). In these paths the message was handled twice — once by FwXWindow.OnMasterRefresh() and again by FwXApp.OnMasterRefresh(). The call in FwXApp appears to be unintentional. There was a comment indicating that this class is no longer an xcore colleague and that the method only remains because there were some direct callers. Even though FwXApp is no longer directly a IxCoreColleague, LexTextApp derives from FwXApp and it is a IxCoreColleague, which resulted in the FwXApp.OnMasterRefresh() being called. Notes: - I removed the activeCache code from FwXWindow.OnMasterRefresh() since there has been only one cache per app for the past several years. - I think FwXWindow.OnMasterRefresh() and FwXApp.RefreshAllWindows() now only differ because FwXApp overrides ActiveForm(). Possible in a future commit, merge these into one method.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1031 +/- ##
=======================================
Coverage 33.04% 33.04%
=======================================
Files 1202 1202
Lines 278319 278313 -6
Branches 37190 37188 -2
=======================================
Hits 91969 91969
+ Misses 158492 158488 -4
+ Partials 27858 27856 -2
🚀 New features to boost your workflow:
|
papeh
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In FwXApp, renamed OnMasterRefresh() to RefreshAllWindows() so that it is not called from the Mediator.
Background:
Six code paths dispatch the MasterRefresh Mediator message in a mode that does not stop at the first handler
(SendMessageToAllNow or BroadcastMessage). In these paths the message was handled twice — once by FwXWindow.OnMasterRefresh() and again by FwXApp.OnMasterRefresh().
The call in FwXApp appears to be unintentional. There was a comment indicating that this class is no longer an xcore colleague and that the method only remains because there were some direct callers. Even though FwXApp is no longer directly a IxCoreColleague, LexTextApp derives from FwXApp and it is a IxCoreColleague, which resulted in the FwXApp.OnMasterRefresh() being called.
Notes:
This change is