test: scope visual snapshots - #219
Draft
Lars Kemper (larskemper) wants to merge 1 commit into
Draft
Conversation
Lars Kemper (larskemper)
force-pushed
the
feat/scoped-visual-snapshots
branch
from
August 14, 2026 12:20
55fc434 to
f2a216d
Compare
Lars Kemper (larskemper)
force-pushed
the
feat/scoped-visual-snapshots
branch
from
August 14, 2026 12:44
f2a216d to
9204f92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scope visual snapshots to page and modal
Changes
expectSnapshothelper that captures.sw-page(or the open.sw-modal__dialog) instead of the full viewportBasicVisualTestandMigrationTesttoexpectSnapshot