ci: verify extension against lowest dependencies - #218
Open
Nikolas Evers (vintagesucks) wants to merge 6 commits into
Open
ci: verify extension against lowest dependencies#218Nikolas Evers (vintagesucks) wants to merge 6 commits into
Nikolas Evers (vintagesucks) wants to merge 6 commits into
Conversation
| run: composer config policy.advisories.block false | ||
|
|
||
| - name: Run verifier | ||
| uses: shopware/github-actions/extension-verifier@extension-verifier-exclude |
Member
Author
There was a problem hiding this comment.
Suggested change
| uses: shopware/github-actions/extension-verifier@extension-verifier-exclude | |
| uses: shopware/github-actions/extension-verifier@main |
Nikolas Evers (vintagesucks)
marked this pull request as ready for review
August 14, 2026 13:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to shopware/SwagMigrationMagento#62
AttributeReader::cleanupColumns()usedgetReferencingColumnNames()andUnqualifiedName(DBAL 4.3+) since fix: phpstan errors #67, so attribute reads through the Shopware local gateway failed on installs whose lockfiles contain an older DBALExtension Verifier (lowest)job usesshopware-cliviashopware/github-actions/extension-verifierto validate the plugin against its lowest resolvable dependencies to catch issues like this in CI in the futureshopware/storefrontadded tosuggest, the verifier installs suggested packages and needs them to resolve the theme classesRunServicepulls in.shopware-extension.ymlinstead of fixed in code, the only in-code fix would be movingsrc/DependencyInjection/*.phptosrc/Resources/config/which felt too heavy hereexample output from the first run of the job: