fix: terminate failed media downloads after retry threshold - #216
Open
Dennis Garding (DennisGarding) wants to merge 8 commits into
Open
fix: terminate failed media downloads after retry threshold#216Dennis Garding (DennisGarding) wants to merge 8 commits into
Dennis Garding (DennisGarding) wants to merge 8 commits into
Conversation
Dennis Garding (DennisGarding)
requested a review
from Lars Kemper (larskemper)
August 11, 2026 11:04
Jozsef Damokos (jozsefdamokos)
approved these changes
Aug 11, 2026
…to 18902/fix-media-download-from-magento
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: shopware/shopware#18902
1. Why is this change necessary?
When a media file cannot be fetched from Magento, the Migration Assistant retries the file without marking it as processed or failed. This causes the downloading progress to exceed the total number of files and prevents the migration from reaching a terminal state.
2. What does this change do, exactly?
Failed media downloads are marked as failed once the configured retry threshold is reached. This ensures that:
Successful downloads keep their existing processing behaviour.