Repository navigation
fix: fall back to WPA2 when the P2P group security type is unreported - #26
Merged
shilapi merged 1 commit intoSep 29, 2026
Merged
Conversation
Android 16 vendor frameworks can leave WifiP2pGroup.securityType unset (-1) after a successful createGroup, which discarded the working group and failed wireless CarPlay startup. Treat unknown types as WPA2-PSK, which is what every group this manager creates already uses.
FudanSE-Nick
force-pushed
the
fix/p2p-security-type-unreported
branch
from
September 28, 2026 16:34
f7afcb9 to
caf0e7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WifiP2pGroupManager.groupSecurity()only accepted the three knownWifiP2pGroup.SECURITY_TYPE_*constants and threwIOExceptionfor every other value.Seen on a Xiaomi build of Android 16, where
createGroupsucceeded but the group came back withsecurityTypeunset (-1). The exception is raised fromawaitUsableGroup()while theWirelessHotspotInfois being built, so it propagates into thecatchinstart(), wherecleanupFailedStart()seescreateSucceeded == trueand callsremoveGroup(). A successfully created group is therefore torn down and the wireless CarPlay start fails.This maps any unrecognised value to
WPA_WPA2and logs the reported value, so an unreported type no longer fails an otherwise usable group.The fallback is safe here because
WifiP2pGroupManageralways builds its config withsetNetworkName()/setPassphrase()and never requests SAE, so every group it creates is WPA2-PSK. The reported WPA3 cases are still honoured when the framework does report them.