Ship CHANGELOG.md in the sdist (0.7.2) - #6
Merged
Merged
Conversation
MANIFEST.in listed CHANGES.md, a 257-byte stub predating the rewritten changelog, and omitted CHANGELOG.md entirely. Source distributions carried no usable changelog as a result. Note that verifying this requires deleting a stale tappay.egg-info/ first: setuptools reuses a cached SOURCES.txt, which kept CHANGES.md in the sdist even after MANIFEST.in stopped listing it, masking the fix. Released as 0.7.2 rather than re-cutting 0.7.1. v0.7.1 is already tagged and pushed at a commit without this fix, and a published artifact should match the tag it claims to be; moving a pushed tag to paper over that is worse than a version bump. 0.7.1 was never published to PyPI. Also adds twine to the dev extra, since publishing is part of the release workflow and it was previously installed ad hoc. No library code changed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packaging only. No library code changed between 0.7.1 and 0.7.2.
MANIFEST.inlistedCHANGES.md— a 257-byte stub predating the rewrittenchangelog — and omitted
CHANGELOG.mdentirely, so source distributions shippedno usable changelog.
A wrinkle worth recording
Verifying this needs a clean
tappay.egg-info/first. setuptools reuses a cachedSOURCES.txt, so the first rebuild after fixingMANIFEST.instill containedCHANGES.mdand looked like the fix had not worked. After removing the staleegg-info:
Why 0.7.2 and not a re-cut 0.7.1
v0.7.1is already tagged and pushed at a commit without this fix. Publishing anartifact called 0.7.1 built from a newer commit would make the released package
disagree with the tag that claims to describe it — a bad property in general and
a worse one for a payments library. Force-moving a pushed tag to hide that is
worse than a version bump, so this goes out as 0.7.2. 0.7.1 was never published
to PyPI, so nothing downstream is affected either way.
Also
twineadded to thedevextra, since publishing is part of the releaseworkflow and it had been installed ad hoc.
🤖 Generated with Claude Code