Add form interaction tests for PasswordForm and ListForm#377
Merged
Conversation
Covers password masking (no plaintext echo), validation failure clearing the buffer, list item collection ending on empty Enter, Ctrl+Delete removing the last item, and the minimum-count validation path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request extends Sharprompt’s end-to-end form interaction test suite to cover the remaining untested form types (PasswordForm and ListForm), validating key user interaction behaviors using the existing scripted console driver harness.
Changes:
- Add PasswordForm interaction tests for masked output (no plaintext echo) and retry behavior on validation failure.
- Add ListForm interaction tests for multi-item collection termination, Ctrl+Delete removal, and minimum-item enforcement.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the form interaction test suite (added in #374) to the two remaining untested form types:
*masking), and a failing validator clears the buffer and lets the user retry.Minimumshows the error and continues.Tests only — no production code changes.
Test plan
dotnet formatclean🤖 Generated with Claude Code