Skip to content

feat: add support for forwarding the entire env - #425

Open
ethanpailes wants to merge 1 commit into
masterfrom
add-forward-all-env
Open

feat: add support for forwarding the entire env#425
ethanpailes wants to merge 1 commit into
masterfrom
add-forward-all-env

Conversation

@ethanpailes

Copy link
Copy Markdown
Contributor

Issue Link

#241

AI Policy Ack

Ack

This PR was:

  • mostly or completely vibe coded
  • mostly or completely meat coded
  • bit of both

Description

This patch extends the forward_env config option so that you can write

forward_env = true

in addition to setting up a fixed list of variables to forward. With this setting enabled, all variables present in the shell that shpool attach was launched from will be forwarded.

Additionally, you can put

forward_env = false

to completely disable env var forwarding. Currently, we have a small handful of variables that we forward by default, so this new false setting allows users to fully prevent them being forwarded if they so desire.

Fixes #241

This patch extends the forward_env config option so that
you can write

```
forward_env = true
```

in addition to setting up a fixed list of variables to forward.
With this setting enabled, all variables present in the shell
that `shpool attach` was launched from will be forwarded.

Additionally, you can put

```
forward_env = false
```

to completely disable env var forwarding. Currently, we have a
small handful of variables that we forward by default, so this new
false setting allows users to fully prevent them being forwarded
if they so desire.

Fixes #241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Inherit CWD and runtime environment

1 participant