fix: standardise devnet url logic on all platforms - #121
Merged
Conversation
Four review fixes, two of them real bugs: - The Android APK launch-extra check failed on every devnet run. `grep -q` exits on the first match, so the SIGPIPE'd `unzip` made the pipeline exit 141 under GitHub's `shell: bash` (`-eo pipefail`) — including on an APK that DOES support the extra. Use `grep -a -c`, which consumes the stream. - That check also treated a missing `strings` as a pass. Dropped `strings` (binutils, not guaranteed on a runner) for `grep -a`, and added a missing-APK guard, so an unverifiable APK can no longer be verified. - `openAppsWithState` awaited resolveNetworkTarget *inside* the Promise.all array, so openAppMultipleDevices had already been invoked before it suspended: a mismatch or dead devnet left devices opening with nothing awaiting them (leaked Appium sessions + an unhandled rejection). Hoisted, so nothing opens until the network is known good. - Devnet refs were only warned about when they differed. Two live seed nodes on two DIFFERENT devnets both probe fine, and the run then seeds through one while a client polls the other. resolveNetworkTarget now proves they are aliases of one devnet by comparing the service-node registries the probe already returns — no extra RPC, no assumption about which oxend field carries a chain identity — and fails before selecting or publishing the seeder ref. The single-ref path (every platform deriving from DEVNET_SEED_URL) is unchanged and still short-circuits. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
mpretty-cyro
approved these changes
Aug 4, 2026
mpretty-cyro
approved these changes
Aug 5, 2026
Bilb
force-pushed
the
feat-standardise-devnet-url
branch
from
August 5, 2026 14:52
b3e8e23 to
174b940
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.