Pro: show hero copy in every Pro status, not just never-subscribed and the sheet - #2163
Open
mpretty-cyro wants to merge 1 commit into
Open
Conversation
…d the sheet The Pro settings header rendered a description only for never-subscribed users, and for expired users in sheet mode. Expired users on the main screen, and active subscribers, saw the image with nothing under it. Pick the string from the status alone, and split the Continue CTA out of that condition so it stays gated on never-subscribed-or-sheet — the expired main screen already offers renewal through ProManage, and iOS and Desktop attach no button to this text either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pro settings header rendered a description only for never-subscribed users, and for expired users in sheet mode. Expired users on the main screen, and active subscribers, saw the image with nothing under it.
Pick the string from the status alone, and split the Continue CTA out of that condition so it stays gated on never-subscribed-or-sheet — the expired main screen already offers renewal through ProManage, and iOS and Desktop attach no button to this text either.