attachments: validate file encryption inputs - #129
Open
Ap4sh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
the file-based attachment encryption overloads currently read 32 bytes from
seedwithout checking its size, unlike the buffer overloads. they also ignoreallow_large, so files aboveMAX_REGULAR_SIZEare accepted when the flag is falsethis validates both inputs before hashing the file while keeping oversized file support when
allow_large=truetests
./Build/tests/testAll "Attachment file encryption validates its inputs"./Build/tests/testAll "[attachments]"./Build/tests/testAll./utils/ci/drone-format-verify.sh