refactor: new rawsmallvec representation - #590
Draft
alejandro-vaz wants to merge 11 commits into
Draft
Conversation
Collaborator
Author
|
will solve it tomorrow |
Contributor
|
Hey Good Idea but this 5 lines kept repeating in the changes: if on_heap {
self.raw.as_heap()
} else {
self.raw.as_inline()
}Why not use a refactored/compatible as_ptr(on_heap) and as_mut_ptr(on_heap) instead? |
Collaborator
Author
|
yeah I haven't done that yet, I wanted to first do it that way and check it works doing so that way erases the length of the array on type data on the inline variant so I was pretty reluctant to do so at first |
Collaborator
Author
|
great... I killed something and I don't know why |
Collaborator
Author
|
I need a few more days for this @fereidani this is a bombshell to how we represent the rawsmallvec, would be grateful I you could provide integration support to make sure that this lands correctly just fixed a bunch of test errors because of some mistake I made whilst remaking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR is a draft
closes #583
closes #441