Get rid of unused GetFieldEvent and GettingFieldEvent - #518
Conversation
GetFieldEvent && GettingFieldEventyGetFieldEvent and GettingFieldEvent
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e1e09a0. Configure here.
| EnsureIsFetched(field); | ||
|
|
||
| Session.CheckForSwitching(); | ||
|
|
There was a problem hiding this comment.
Required field-get subscriptions removed
Medium Severity
This change removes entity-level field-get subscriptions (GettingFieldEventKey and GetFieldEventKey), so EntityEventBroker subscribers no longer run when a field is read. Those entity-level get subscriptions remain required, even after session field-get events were removed.
Additional Locations (2)
Triggered by learned rule: No session event on entity field get
Reviewed by Cursor Bugbot for commit e1e09a0. Configure here.


Yet one hook on Field reading
Note
Medium Risk
Touches the core field-read hot path and removes public event keys; any external subscriber to the removed hooks would break, though the PR treats them as unused.
Overview
Removes the Getting field and Get field extension points from the entity/structure field read pipeline, leaving only the pre-read work in
SystemBeforeGetValue(fetch, session checks, debug logging).EntityEventBrokerno longer exposesGettingFieldEventKeyorGetFieldEventKey. Subscriber dispatch for those keys is deleted fromEntityandStructure, and the abstractSystemGetValue<T>hook is removed fromPersistentalong with all post-read invocations inGetNormalizedFieldValueandGetReferenceKey. Field set events (SettingField*,SetField*) are unchanged.Reviewed by Cursor Bugbot for commit e1e09a0. Bugbot is set up for automated code reviews on this repo. Configure here.