Skip to content

Get rid of unused GetFieldEvent and GettingFieldEvent - #518

Merged
SergeiPavlov merged 1 commit into
master-servicetitanfrom
GetFieldEventKey
Aug 28, 2026
Merged

Get rid of unused GetFieldEvent and GettingFieldEvent#518
SergeiPavlov merged 1 commit into
master-servicetitanfrom
GetFieldEventKey

Conversation

@SergeiPavlov

@SergeiPavlov SergeiPavlov commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Yet one hook on Field reading


Note

Medium Risk
Touches the core field-read hot path and removes public event keys; any external subscriber to the removed hooks would break, though the PR treats them as unused.

Overview
Removes the Getting field and Get field extension points from the entity/structure field read pipeline, leaving only the pre-read work in SystemBeforeGetValue (fetch, session checks, debug logging).

EntityEventBroker no longer exposes GettingFieldEventKey or GetFieldEventKey. Subscriber dispatch for those keys is deleted from Entity and Structure, and the abstract SystemGetValue<T> hook is removed from Persistent along with all post-read invocations in GetNormalizedFieldValue and GetReferenceKey. Field set events (SettingField*, SetField*) are unchanged.

Reviewed by Cursor Bugbot for commit e1e09a0. Bugbot is set up for automated code reviews on this repo. Configure here.

@SergeiPavlov SergeiPavlov changed the title Get rid of unused GetFieldEvent && GettingFieldEventy Get rid of unused GetFieldEvent and GettingFieldEvent Aug 27, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e1e09a0. Configure here.

EnsureIsFetched(field);

Session.CheckForSwitching();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required field-get subscriptions removed

Medium Severity

This change removes entity-level field-get subscriptions (GettingFieldEventKey and GetFieldEventKey), so EntityEventBroker subscribers no longer run when a field is read. Those entity-level get subscriptions remain required, even after session field-get events were removed.

Additional Locations (2)
Fix in Cursor Fix in Web

Triggered by learned rule: No session event on entity field get

Reviewed by Cursor Bugbot for commit e1e09a0. Configure here.

@SergeiPavlov
SergeiPavlov merged commit 7e4e2b4 into master-servicetitan Aug 28, 2026
91 checks passed
@SergeiPavlov
SergeiPavlov deleted the GetFieldEventKey branch August 28, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants