Skip to content

Get rid of unused EntityFieldValueGet event - #517

Merged
SergeiPavlov merged 2 commits into
master-servicetitanfrom
EntityFieldValueGet
Aug 27, 2026
Merged

Get rid of unused EntityFieldValueGet event#517
SergeiPavlov merged 2 commits into
master-servicetitanfrom
EntityFieldValueGet

Conversation

@SergeiPavlov

@SergeiPavlov SergeiPavlov commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Note

Medium Risk
Removes a public session event, which is a breaking change for external subscribers even if unused internally.

Overview
Removes the EntityFieldValueGet session event and all code that raised it when entity field values were read.

SessionEventAccessor no longer exposes the event or NotifyFieldValueGet. Entity.SystemGetValue no longer notifies system or session events on get; entity-level get subscriptions are unchanged. SessionEventsTest drops EntityFieldValueGet wiring and assertions that expected the event after reading a property.

This is a breaking public API change for any code that subscribed to EntityFieldValueGet; field set events are unaffected.

Reviewed by Cursor Bugbot for commit cb8d7d0. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8a24371. Configure here.

Comment thread Orm/Xtensive.Orm.Tests/Storage/SessionEventsTest.cs
@SergeiPavlov
SergeiPavlov merged commit 3561f39 into master-servicetitan Aug 27, 2026
62 checks passed
@SergeiPavlov
SergeiPavlov deleted the EntityFieldValueGet branch August 27, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants