Skip to content

Get rid of unused EntityFieldValueGetCompleted event - #516

Merged
SergeiPavlov merged 1 commit into
master-servicetitanfrom
EntityFieldValueGetCompleted
Aug 27, 2026
Merged

Get rid of unused EntityFieldValueGetCompleted event#516
SergeiPavlov merged 1 commit into
master-servicetitanfrom
EntityFieldValueGetCompleted

Conversation

@SergeiPavlov

@SergeiPavlov SergeiPavlov commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Note

Medium Risk
This is a breaking public API change for any subscriber to Session.Events.EntityFieldValueGetCompleted; behavior on failed field reads no longer surfaces through that event.

Overview
Removes the EntityFieldValueGetCompleted session event and its EntityFieldValueGetCompletedEventArgs type, along with the internal SystemGetValueCompleted hook on Persistent, Entity, and Structure.

Field read paths in Persistent (GetNormalizedFieldValue, GetReferenceKey) no longer wrap reads in try/catch solely to raise a completion event with success or failure. EntityFieldValueGet and the existing get-time hooks are unchanged; only the post-read “completed” notification (including on exceptions) is gone.

Reviewed by Cursor Bugbot for commit c589e36. Bugbot is set up for automated code reviews on this repo. Configure here.

@SergeiPavlov
SergeiPavlov merged commit 5ddb2c3 into master-servicetitan Aug 27, 2026
64 checks passed
@SergeiPavlov
SergeiPavlov deleted the EntityFieldValueGetCompleted branch August 27, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants