Skip to content

Get rid of unused EntityFieldValueGetting Session event - #515

Merged
SergeiPavlov merged 1 commit into
master-servicetitanfrom
EntityFieldValueGetting
Aug 27, 2026
Merged

Get rid of unused EntityFieldValueGetting Session event#515
SergeiPavlov merged 1 commit into
master-servicetitanfrom
EntityFieldValueGetting

Conversation

@SergeiPavlov

@SergeiPavlov SergeiPavlov commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Yet one hook with some overhead


Note

Medium Risk
This is a breaking public API change for any consumer that subscribed to EntityFieldValueGetting; behavior for post-read EntityFieldValueGet is unchanged.

Overview
Removes the EntityFieldValueGetting session hook and the EntityFieldEventArgs type that fired before a field value was read. Field reads no longer raise a pre-get notification on Session.Events / system events; EntityFieldValueGet (after a successful read, with the value) is unchanged.

Entity.SystemBeforeGetValue no longer calls NotifyFieldValueGetting, which drops per-read event overhead on the hot path. SessionEventsTest was updated to stop subscribing to or asserting on the removed event.

Reviewed by Cursor Bugbot for commit 8f06332. Bugbot is set up for automated code reviews on this repo. Configure here.

@SergeiPavlov
SergeiPavlov merged commit aefa091 into master-servicetitan Aug 27, 2026
64 checks passed
@SergeiPavlov
SergeiPavlov deleted the EntityFieldValueGetting branch August 27, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants