Get rid of unused EntityFieldValueGetting Session event - #515
Merged
Conversation
botinko
approved these changes
Aug 27, 2026
snaumenko-st
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yet one hook with some overhead
Note
Medium Risk
This is a breaking public API change for any consumer that subscribed to
EntityFieldValueGetting; behavior for post-readEntityFieldValueGetis unchanged.Overview
Removes the
EntityFieldValueGettingsession hook and theEntityFieldEventArgstype that fired before a field value was read. Field reads no longer raise a pre-get notification onSession.Events/ system events;EntityFieldValueGet(after a successful read, with the value) is unchanged.Entity.SystemBeforeGetValueno longer callsNotifyFieldValueGetting, which drops per-read event overhead on the hot path.SessionEventsTestwas updated to stop subscribing to or asserting on the removed event.Reviewed by Cursor Bugbot for commit 8f06332. Bugbot is set up for automated code reviews on this repo. Configure here.