Get rid of unused OnGettingFieldValue() - #514
Merged
Merged
Conversation
snaumenko-st
approved these changes
Aug 27, 2026
botinko
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
API-breaking only if a consumer overrode the removed hook; runtime field-read behavior for subscriptions and session events is unchanged.
Overview
Removes the protected virtual
OnGettingFieldValue(FieldInfo)hook fromPersistentand stops invoking it fromEntity.SystemBeforeGetValueandStructure.SystemBeforeGetValue.Pre-read field access is unchanged for
EntityEventBroker.GettingFieldEventKeysubscribers and the existing session/system field-getting events; only the unused override point is dropped.Reviewed by Cursor Bugbot for commit 466406d. Bugbot is set up for automated code reviews on this repo. Configure here.