Fix IndexOutOfRangeException when an Enum's MetadataToken collides with Nullable<T> - #513
Merged
Merged
Conversation
added 2 commits
August 10, 2026 22:26
botinko
approved these changes
Aug 26, 2026
snaumenko-st
approved these changes
Aug 26, 2026
…datatoken-collision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of DataObjects-NET#472
Note
Medium Risk
Changes core packed-tuple field accessor resolution; behavior is narrowed to fix a rare token collision bug, with regression tests covering the edge case.
Overview
Fixes
IndexOutOfRangeExceptionduringTupleDescriptor.Createwhen a tuple field type is an enum whoseMetadataTokenmatchesNullable<T>but lives in a different module.In
TupleLayout.ValueFieldAccessorResolver.GetValue, nullable unwrap for enum underlying-type resolution now requires both the knownNullable<>metadata token and the same module asWellKnownTypes.NullableOfT, instead of token alone. That stops non-generic enums from being treated likeNullable<>and callingGetGenericArguments()[0]on them.Adds
NullableTokenCollisionTest, which emits filler types so a dynamic enum sharesNullable<>’s token in another assembly, and asserts tuple descriptor creation for the plain enum and forNullable<that enum>both succeed.Reviewed by Cursor Bugbot for commit bbe91de. Bugbot is set up for automated code reviews on this repo. Configure here.