Get rid of unused OnGetFieldValue() - #512
Merged
Merged
Conversation
snaumenko-st
approved these changes
Aug 26, 2026
botinko
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also:
GetNormalizedFieldValue()Note
Medium Risk
Removes a public override point and touches the core field-read path; behavior change only for code that overrode
OnGetFieldValue, with a low chance of subtle event/subscriber differences.Overview
Removes the unused
OnGetFieldValueoverride hook fromPersistent(and theEntity/Structurecalls that invoked it). Field-read side effects should rely on existing sessionEntityFieldValueGetevents and entity event broker subscribers instead.SystemGetValue/SystemGetValueCompletedandSessionEventAccessor’s matching notify methods are now generic over the read value type. TypedGetNormalizedFieldValue<T>passes the result through that pipeline directly, so value-type fields no longer get an extraobjectboxing step on every read.Untyped
GetNormalizedFieldValue/ reference paths are unchanged in shape; session event args still exposeobjectvalues when notifications run.Reviewed by Cursor Bugbot for commit 465496a. Bugbot is set up for automated code reviews on this repo. Configure here.