Skip to content

Get rid of unused OnGetFieldValue() - #512

Merged
SergeiPavlov merged 1 commit into
master-servicetitanfrom
OnGetFieldValue
Aug 26, 2026
Merged

Get rid of unused OnGetFieldValue()#512
SergeiPavlov merged 1 commit into
master-servicetitanfrom
OnGetFieldValue

Conversation

@SergeiPavlov

@SergeiPavlov SergeiPavlov commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Also:

  • avoid boxing on every field reading in GetNormalizedFieldValue()

Note

Medium Risk
Removes a public override point and touches the core field-read path; behavior change only for code that overrode OnGetFieldValue, with a low chance of subtle event/subscriber differences.

Overview
Removes the unused OnGetFieldValue override hook from Persistent (and the Entity / Structure calls that invoked it). Field-read side effects should rely on existing session EntityFieldValueGet events and entity event broker subscribers instead.

SystemGetValue / SystemGetValueCompleted and SessionEventAccessor’s matching notify methods are now generic over the read value type. Typed GetNormalizedFieldValue<T> passes the result through that pipeline directly, so value-type fields no longer get an extra object boxing step on every read.

Untyped GetNormalizedFieldValue / reference paths are unchanged in shape; session event args still expose object values when notifications run.

Reviewed by Cursor Bugbot for commit 465496a. Bugbot is set up for automated code reviews on this repo. Configure here.

@SergeiPavlov
SergeiPavlov merged commit 4a3f5e2 into master-servicetitan Aug 26, 2026
64 checks passed
@SergeiPavlov
SergeiPavlov deleted the OnGetFieldValue branch August 26, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants