Get rid of AdjustFieldValue() - #511
Merged
Merged
Conversation
botinko
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This virtual method has never been overridden
And it adds some overhead to every Entity field access.
Note
Low Risk
Removes an unused public virtual API; behavior is unchanged unless external subclasses overrode AdjustFieldValue, which the PR states did not happen in this repo.
Overview
Removes the
AdjustFieldValueextension points fromPersistent(read and write overloads) and stops calling them on every field get/set.Field reads now pass the accessor value straight into
SystemGetValue/SystemGetValueCompletedwithout an extra object round-trip and cast. Writes assign the incoming value directly viaSetUntypedValueinstead of transforming it throughAdjustFieldValuefirst.This is a hot-path cleanup: the hooks were never overridden in the codebase but still added work on each entity field access.
Reviewed by Cursor Bugbot for commit 2d02ad2. Bugbot is set up for automated code reviews on this repo. Configure here.