Repository navigation
ENH(smc): add independent beta search tolerance - #146
Merged
Merged
Conversation
mj-will
marked this pull request as ready for review
October 31, 2026 07:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard adaptive SMC uses
min_deltaboth as the minimum beta increment and the bisection tolerance. Add an optionalbeta_toleranceto control search precision independently;Nonepreserves the existing behavior. The standard sampler exposes it throughweighting_kwargs, alongsidemax_bisection_iter.Tests cover independent precision, the minimum-step bound, default compatibility, invalid tolerances, sampler integration, and JAX compilation. Validation: default suite 1,282 passed / 367 skipped; two targeted JAX tests passed; pre-commit (including mypy) and docs build passed. GPU and PyTorch checks were not run.