test(core): Honor typed-receiver instance-method sanitizers#261
Open
misonijnik wants to merge 1 commit into
Open
test(core): Honor typed-receiver instance-method sanitizers#261misonijnik wants to merge 1 commit into
misonijnik wants to merge 1 commit into
Conversation
Minimal repro on top of main for the engine gap behind the path-traversal FP (`(java.io.File $F).getCanonicalFile()` fails to sanitize). Root cause found by reading the engine: cleaners/sanitizers are applied only for rules carrying UserRuleFromSemgrepInfo (JIRMethodCallRuleBasedSummaryRewriter does `cleanRule.info as? UserDefinedRuleInfo ?: continue`), so a low-level SerializedTaintConfig cleaner (info=null) is never applied — sanitizers are semgrep-only. The low-level function matcher is name-based (matches instance and static alike), so the instance-vs-static divergence must be in the semgrep pattern->matcher compilation. The working example uses a metavar receiver `$A.getObjBad()`; the failing path-traversal sanitizers use a TYPED receiver `(File $F).getCanonicalFile()`. Repro (querylang SampleBasedTest, real SemgrepRuleLoader -> createTaintConfig): taint/InstanceSanitizerRepro with a `(Box $B).sanitize()` typed-receiver pattern-sanitizer. Positive is flagged (correct); Negative (value passed through the sanitizer) is ALSO flagged — the repro. TaintTest."instance-method typed-receiver sanitizer repro" fails today and should pass once typed-receiver instance-method sanitizers are honored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.