test(core): Fix pattern-propagator to handle taint in concatenated args#260
Closed
misonijnik wants to merge 2 commits into
Closed
test(core): Fix pattern-propagator to handle taint in concatenated args#260misonijnik wants to merge 2 commits into
misonijnik wants to merge 2 commits into
Conversation
…ctor arg Repro for the residual #2 gap behind the path-traversal FN `new java.net.URL("file:///..." + resource)` -> HttpResponses.staticResource(url). taint/WrapperPropagatorRepro: a pattern-propagator `$W = new Wrapper($SPEC)` (from $SPEC to $W). PositiveDirect (`new Wrapper(data)`) is reported; PositiveConcat (`new Wrapper("prefix/" + data)`) is MISSED — the propagator does not observe taint when the constructor argument is a string concatenation. Same shape as the ssrf URL[] case that DOES work (direct var), isolating the concat as the trigger. TaintTest."wrapper propagator concat-arg repro" fails today (PositiveConcat missed) and should pass once propagators see taint through concatenated arguments.
Saloed
force-pushed
the
misonijnik/repros-propagator
branch
from
bba5b18 to
b1ef3af
Compare
Contributor
|
@misonijnik This test doesn't reproduce the mentioned issue. The actual test fail reason: config disabled in tests by default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.