Repository navigation
fix(deps): upgrade golang.org/x/crypto to v0.52.0 (COMP-2460) - #76
Closed
cristianrcv wants to merge 1 commit into
Closed
cristianrcv wants to merge 1 commit into
cristianrcv wants to merge 1 commit into
Conversation
The FIDO/U2F Verify() path in x/crypto/ssh did not check the User Presence flag, so signatures produced without a physical touch were accepted. Bumping to the first patched release closes the bypass. x/crypto v0.52.0 declares go 1.25.0, so the go directive moves from 1.24.3 to 1.25.0; CI already builds with Go 1.27.1. go get pulled the matching x/net, x/sync, x/sys and x/text bumps. Addresses CVE-2026-39831 / GHSA-89gr-r52h-f8rx See: https://github.com/seqeralabs/staticreg/security/dependabot/17 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Discarded in favour of #71 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golang.org/x/cryptofromv0.38.0tov0.52.0The
Verify()method for FIDO/U2F security key types (sk-ecdsa-sha2-nistp256@openssh.com,sk-ssh-ed25519@openssh.com) did not check the User Presence flag, so signatures generated without a physical touch were accepted.Notes
golang.org/x/cryptois an indirect requirement (pulled in viagin→validator/v10→x/crypto/sha3). No parent upgrade can resolve it: every parent requires a version below0.52.0, so under MVS thego.modrequire line is the only lever. Noreplacedirective, constraint or force-pin was used.x/crypto v0.52.0declaresgo 1.25.0, so thegodirective moves1.24.3→1.25.0. CI already builds with Go 1.27.1, so no workflow change was needed.go getpulled the matchingx/net,x/sync,x/sysandx/textbumps.Verification
go mod verify,go build ./...,go vet ./...andgo test ./...all pass locally.JIRA
COMP-2460: Fix golang.org/x/crypto: FIDO/U2F security key physical presence check can be bypassed
Security Advisory
https://github.com/seqeralabs/staticreg/security/dependabot/17
🤖 Generated with Claude Code