Skip to content

[fix] workaround bug in cereal#197

Merged
h-2 merged 1 commit into
seqan:lambda3from
h-2:serial
Nov 10, 2022
Merged

[fix] workaround bug in cereal#197
h-2 merged 1 commit into
seqan:lambda3from
h-2:serial

Conversation

@h-2

@h-2 h-2 commented Nov 10, 2022

Copy link
Copy Markdown
Member

Can you check the (de)serialisation performance with this branch?

@h-2 h-2 requested a review from sarahet November 10, 2022 19:12
@sarahet

sarahet commented Nov 10, 2022

Copy link
Copy Markdown
Member

Clang format is failing 🙂

@sarahet

sarahet commented Nov 10, 2022

Copy link
Copy Markdown
Member

Index loading time:

This branch - 12.558s
This branch with #191 - 9.899s
@SGSSGene's workaround and #191 - 10.4s

@sarahet sarahet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-2 h-2 merged commit 28d3b69 into seqan:lambda3 Nov 10, 2022
@h-2

h-2 commented Nov 10, 2022

Copy link
Copy Markdown
Member Author

Thanks for evaluating it!

@h-2

h-2 commented Nov 10, 2022

Copy link
Copy Markdown
Member Author

This is the upstream issue: USCiLab/cereal#769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants