Fix NullPointerException in EmpowerPlantActivity cart count observer - #264
Open
cursor[bot] wants to merge 1 commit into
Open
Fix NullPointerException in EmpowerPlantActivity cart count observer#264cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add null check for textCartItemCount before calling setText() in onResume. The observer fires before onCreateOptionsMenu initializes the TextView, causing a crash when the cart has items on activity startup. Fixes [ANDROID-HZ](https://demo.sentry.io/issues/7562174288/)
ndmanvar
marked this pull request as ready for review
August 21, 2026 10:12
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 883 885 +2
Branches 67 67
=====================================
- Misses 883 885 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In EmpowerPlantActivity, the cart count observer fires in onResume before onCreateOptionsMenu initializes textCartItemCount, causing a NullPointerException when the cart has items on activity startup.
Root Cause
onResumebefore the options menu is inflatedonCreateOptionsMenu(which initializestextCartItemCount) runs afteronResumein the Activity lifecyclesetText()on a nulltextCartItemCountreferenceSolution
Added a null check for
textCartItemCountbefore callingsetText()in the observer withinonResume. This prevents the crash while allowing the UI to update once the menu is created.Testing
Fixes ANDROID-HZ