Fix ArrayIndexOutOfBoundsException in MyBaseActivity.createTempFileSecure() - #252
Draft
cursor[bot] wants to merge 1 commit into
Draft
Fix ArrayIndexOutOfBoundsException in MyBaseActivity.createTempFileSecure()#252cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…cure() Change guard condition from 'index > cacheFiles.length' to 'index >= cacheFiles.length' to properly reject index values equal to the array length. Since Java arrays are 0-indexed, valid indices are 0 to length-1, so index == length must be rejected. Fixes [ANDROID-M7](https://demo.sentry.io/issues/7657614514/)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 883 883
Branches 67 67
=====================================
Misses 883 883 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an off-by-one error in the array bounds check that caused ArrayIndexOutOfBoundsException when accessing cache files.
Problem
The guard condition in
createTempFileSecure()at line 163 usedindex > cacheFiles.lengthinstead ofindex >= cacheFiles.length, allowing index values equal to the array length to pass the bounds check. Since Java arrays are 0-indexed with valid indices from 0 to length-1, an index equal to the array length would cause an ArrayIndexOutOfBoundsException when accessing the array.Solution
Changed the guard condition from
>to>=to properly reject index values that are out of bounds.Testing
cacheFiles.lengthfrom passing the guardFixes ANDROID-M7