Fix NullPointerException in cart badge update - #245
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Add null check before updating textCartItemCount TextView to prevent NullPointerException when observer fires in onResume before onCreateOptionsMenu initializes the view. The issue occurred because: - onResume subscribes to StoreItemDAO.observeSelectedCount() - Observer emits immediately upon subscription - onCreateOptionsMenu (which initializes textCartItemCount) runs after onResume - setText() was called on null reference causing crash Fixes [ANDROID-JA](https://demo.sentry.io/issues/7591013844/)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 883 885 +2
Branches 67 67
=====================================
- Misses 883 885 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a NullPointerException that occurs when updating the cart badge in
EmpowerPlantActivity.Problem
The crash occurred because:
onResume()subscribes toStoreItemDAO.observeSelectedCount()which emits immediatelytextCartItemCountTextViewtextCartItemCountis only initialized inonCreateOptionsMenu(), which runs afteronResume()in the Activity lifecyclesetText()being called on a null referenceSolution
Added a null check before updating the TextView in the observer callback. If the menu hasn't been created yet, the update is skipped. The badge will be updated correctly on subsequent emissions after the menu is initialized.
Changes
textCartItemCount.setText()in the RxJava observerFixes ANDROID-JA