Fix checkout flow calling processDeliveryItem on failure - #238
Open
sentry[bot] wants to merge 1 commit into
Open
Fix checkout flow calling processDeliveryItem on failure#238sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
- Gate processDeliveryItem() on successful HTTP response only; on HTTP error (e.g. 500 from /checkout), finish the transaction with INTERNAL_ERROR without attempting the delivery workflow. - Remove unconditional 'throw BackendAPIException' from processDeliveryItem() so it completes normally on success. - Remove processDeliveryItem() call from onFailure callback since a network failure also means checkout did not succeed. Fixes [ANDROID-J4](https://demo.sentry.io/issues/7576244315/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Android checkout flow unconditionally calls
processDeliveryItem()after every checkout attempt — even when the backend returns HTTP 500. Additionally,processDeliveryItem()unconditionally throws aBackendAPIException, so it always fails regardless of checkout success.Changes
Gate
processDeliveryItem()on successful HTTP response only — on HTTP error (e.g. 500 from/checkout), finish the transaction withINTERNAL_ERRORwithout attempting the delivery workflow.Remove unconditional
throw BackendAPIExceptionfromprocessDeliveryItem()— the method now completes normally, setting the span status toOK.Remove
processDeliveryItem()call fromonFailurecallback — a network failure also means checkout did not succeed, so the delivery workflow should not be attempted.Fixes ANDROID-J4