Skip to content

release: 0.55.0 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arbianst merged 1 commit into from
Nov 12, 2026
Merged

release: 0.55.0 #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .release-please-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
".": "0.54.0"
".": "0.55.0"
}
11 changes: 11 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
# Changelog

## [0.55.0](https://github.com/sentdm/sent-dm-python/compare/v0.54.0...v0.55.0) (2026-11-12)


### ⚠ BREAKING CHANGES

* **api:** sync OpenAPI spec from production

### Features

* **api:** sync OpenAPI spec from production ([a492eb1](https://github.com/sentdm/sent-dm-python/commit/a492eb1a8a57db542be2045ac8a6be27d535cf50))
Comment on lines +6 to +12

@claude claude Bot Nov 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Customers upgrading to 0.55.0 get a BREAKING CHANGES note that doesn't say what broke or what to do. The only line is "sync OpenAPI spec from production", an internal cause. CLAUDE.md asks for subjects that state "what changed, and what to do about it. Never an internal cause." This release removes SMSMarket.sender_value with no alias, so code reading it breaks with no warning. Fix: before merging, rewrite both 0.55.0 lines (CHANGELOG.md:8 and :12) and the release PR body. Name the removed sender_value field, its replacement in numbers, and the new payment-method requirement. A BEGIN_COMMIT_OVERRIDE in the PR body is one way to do it.

Why this was flagged

The changelog text is copied from the subject of commit a492eb1, feat(api)!: sync OpenAPI spec from production. CHANGELOG.md:8 and :12 both repeat that subject, so the BREAKING CHANGES section names no field, method or behaviour. Commit a492eb1 deletes sender_value: Optional[str] from src/sent_dm/types/channels/sms_market.py with no alias. A customer who reads market.sender_value gets an AttributeError after upgrading, and the release notes give no hint of the cause or the replacement (numbers). The same commit adds a payment-method requirement for call participants (payment_method_missing in src/sent_dm/types/voice/call.py), and the notes don't mention it either. Unlike the 0.54.0 entry, which spells out what changed, this one tells customers nothing they can act on. CLAUDE.md marks CHANGELOG.md as owned by release-please, but that only means rewriting it in a release PR is expected. It does not exempt the text from the rule about customer-readable subjects. I checked this by reading the diff and the commit; nothing was run.

Verification: CHANGELOG.md:8 (under "### ⚠ BREAKING CHANGES") and CHANGELOG.md:12 both say only "api: sync OpenAPI spec from production". The text names an internal process, not a customer-facing change. git show a492eb1 -- src/sent_dm/types/channels/sms_market.py deletes sender_value: Optional[str] = None from SMSMarket, and no alias remains.


## [0.54.0](https://github.com/sentdm/sent-dm-python/compare/v0.53.0...v0.54.0) (2026-11-06)


Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "sentdm"
version = "0.54.0"
version = "0.55.0"
description = "The official Python library for the Sent API"
dynamic = ["readme"]
license = "Apache-2.0"
Expand Down
2 changes: 1 addition & 1 deletion src/sent_dm/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# File generated from our OpenAPI spec by Stainless. See CONTRIBUTING.md for details.

__title__ = "sent_dm"
__version__ = "0.54.0" # x-release-please-version
__version__ = "0.55.0" # x-release-please-version
Loading