Skip to content

[UIK-5778][scroll-area] added early exit from calculateSizeContainer for components without wMax and hMax #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ilyabrower wants to merge 2 commits into from
+8 −1
Closed

[UIK-5778][scroll-area] added early exit from calculateSizeContainer for components without wMax and hMax #3136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a85d8d
[scroll-area] added early exit from calculateSizeContainer for compon…
ilyabrower Aug 19, 2026
057467a
[data-table] fixed loading spinner for grouped headers and scroll ins…
ilyabrower Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions semcore/base-components/src/components/scroll-area/ScrollArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ class ScrollAreaRoot extends Component<
const { wMax, hMax, observeParentSize } = this.asProps;
const size = { width: '', height: '' };
if (!this.$container || !this.$wrapper) return size;
if (!wMax && !hMax) return size;
const { scrollWidth, scrollHeight } = this.$container;
const style = window.getComputedStyle(this.$wrapper);
const parent = this.$wrapper.parentElement;
Expand Down
2 changes: 2 additions & 0 deletions semcore/data-table/src/components/Body/Body.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ class BodyRoot<Data extends DataTableData, UniqKeyType> extends Component<DataTa
rows,
renderCellOverlay,
selectedRows,
hasGroups,
} = this.asProps;

let rowsToRender = rows;
Expand Down Expand Up @@ -394,6 +395,7 @@ class BodyRoot<Data extends DataTableData, UniqKeyType> extends Component<DataTa
<SSpinContainer
innerOutline
// @ts-ignore
hasGroups={hasGroups}
headerHeight={`${this.getSpinnerTopOffset()}px`}
tabIndex={-1}
ref={spinnerRef}
Expand Down
6 changes: 5 additions & 1 deletion semcore/data-table/src/components/Body/style.shadow.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,10 +284,14 @@ SSpinContainer {

&[headerHeight] {
position: sticky;
top: 0;
top: var(--headerHeight);
height: min(100vh, calc(var(--global-table-height) - var(--headerHeight)));
min-height: min(100vh, calc(var(--global-table-height) - var(--headerHeight)));
}

&[hasGroups] {
grid-area: 3 / 1 / 20 / 5;
}
}

SEmptyData {
Expand Down
Loading