Skip to content

[UIK-5669][accordion] rebranding - #3135

Open
j-mnizhek wants to merge 4 commits into
UIK-5351/add-more-variables-to-themefrom
UIK-5669/accordion-rebranding
Open

[UIK-5669][accordion] rebranding#3135
j-mnizhek wants to merge 4 commits into
UIK-5351/add-more-variables-to-themefrom
UIK-5669/accordion-rebranding

Conversation

@j-mnizhek

Copy link
Copy Markdown
Member

Motivation and Context

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

Comment thread semcore/accordion/src/style/accordion.shadow.css
}

SItemToggle[use][use='primary'] {
box-sizing: border-box;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this?

Comment thread semcore/accordion/src/style/accordion.shadow.css
Comment thread semcore/accordion/src/style/accordion.shadow.css
SItemToggle[use][use='primary']:has(SItemChevron[selected])::before {
opacity: 1;
}
SItemToggle[use][use='primary']:has(SItemChevron[selected]) + * {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think, we can use here more relevant selector

</Accordion.Item.Toggle>
<Accordion.Item.Collapse>
<Box pt={3} px={6} pb={6}>{`This is section ${index + 1}`}</Box>
<Box pt={3} px={5} pb={6}>{`This is section ${index + 1}`}</Box>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this padding should be in Collapse component...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree, but there is a nuance... We'll discuss this

@j-mnizhek
j-mnizhek marked this pull request as ready for review August 19, 2026 12:00
@j-mnizhek j-mnizhek changed the title UI k 5669/accordion rebranding [UIK-5669][accordion] rebranding Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants