[UIK-5641][notice] redesign - #3102
Conversation
ilyabrower
changed the title
50b502b to
ae15809
Compare
…5641/notice-redesign
…les-to-theme' into UIK-5641/notice-redesign
…les-to-theme' into UIK-5641/notice-redesign
…les-to-theme' into UIK-5641/notice-redesign
github-actions
Bot
added
base-components
tooltip
inline-input
ellipsis
data-table
bulk-textarea
labels
github-actions
Bot
removed
bulk-textarea
card
data-table
drag-and-drop
ellipsis
inline-input
tooltip
labels
…ice-redesign Signed-off-by: Valeria-Zimnitskaya <valeryia.zimnitskaya@semrush.com>
…/semrush/intergalactic into UIK-5641/notice-redesign
| height: fit-content; | ||
| display: inline-flex; | ||
| align-items: center; | ||
| margin-top: 6px; |
There was a problem hiding this comment.
@ilyabrower @sheila-semrush is that ok that the value is hardcoded?
| margin-right: var(--intergalactic-spacing-2x, 8px); | ||
| display: inline-flex; | ||
| align-items: center; | ||
| margin-top: 6px; |
There was a problem hiding this comment.
@ilyabrower @sheila-semrush is that ok that the value is hardcoded?
| } & ({ | ||
| icon?: typeof Icon; | ||
| } | { | ||
| illustration?: React.ElementType<IllustrationProps>; |
There was a problem hiding this comment.
@ilyabrower Maybe here should be same logic as for Notice Smart?
There was a problem hiding this comment.
I think yes, fixed
| margin-left: var(--intergalactic-spacing-content-padding-large, 16px); | ||
| } | ||
|
|
||
| SNotice[theme='custom'] { |
There was a problem hiding this comment.
@sheila-semrush @ilyabrower is that expected behavior to use custom theme?
If yes, should icon color change with custom theme?
| border-width: 1px; | ||
| border-radius: var(--intergalactic-surface-rounded, 8px); | ||
| color: var(--intergalactic-text-primary, oklch(0.1 0.03 137 / 0.899)); | ||
| gap: var(--intergalactic-spacing-content-gap-large, 8px); |
There was a problem hiding this comment.
@sheila-semrush in figma i see spacing-content-padding-small could you help which is expected
There was a problem hiding this comment.
gap - for gap =)
| flex-shrink: 0; | ||
| margin-top: var(--intergalactic-spacing-3x, 12px); | ||
| display: flex; | ||
| gap: var(--intergalactic-spacing-content-gap-large, 8px); |
There was a problem hiding this comment.
@sheila-semrush same, in figma i see other value spacing-content-padding-small
| @@ -82,44 +83,59 @@ SContent { | |||
|
|
|||
| SActions { | |||
There was a problem hiding this comment.
@sheila-semrush is necessary align-items: center here ? as in figma
…/intergalactic into UIK-5641/notice-redesign
…/intergalactic into UIK-5641/notice-redesign
4 participants
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: