Repository navigation
build(deps-dev): move vitest and coverage-v8 to 5.x together - #164
Merged
Merged
Conversation
Dependabot opened these as #162 and #163. Either one merged alone leaves @vitest/coverage-v8 and vitest on different majors (coverage-v8 pins an exact vitest peer), and whichever merged first would conflict the other's lockfile, so they go in as one change. No config changes were needed: the root and integration vitest configs run unchanged on 5.0.5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #162 and #163. Dependabot should close both once this lands; if it doesn't, close them by hand.
Why one PR
@vitest/coverage-v8pins an exactvitestpeer, so merging either bump alone leaves the two on different majors (pnpm warns about the unmet peer). Whichever merged first would also conflict the other's lockfile.Changes
vitest^4.1.11 → ^5.0.5 in the root and every workspace package@vitest/coverage-v8^4.1.11 → ^5.0.5Checked locally
pnpm lint(0 errors; the one warning is the existing one indashboard/src/pages/Admin.tsx),pnpm typecheckpnpm test:unit: 736/736pnpm test:coverage: passespnpm test:integration: 18/18 against the dev stack with the fixture jobs seededpnpm audit --audit-level high: nothing at high or aboveRunning integration locally needs the fixture Agent jobs seeded first (
deploy/sql-seed/seed.sql), the same way CI does it. Without them, 17 of 18 tests time out waiting for jobs, onmainas well.🤖 Generated with Claude Code