Repository navigation
build(deps): bump minor-and-patch group (14 updates) and regenerate protobuf - #155
Merged
Merged
Conversation
…4 updates Bumps the minor-and-patch group with 14 updates in the / directory: | Package | From | To | | --- | --- | --- | | [@bufbuild/buf](https://github.com/bufbuild/buf) | `1.74.0` | `1.75.0` | | [ts-proto](https://github.com/stephenh/ts-proto) | `2.17.0` | `2.18.3` | | [turbo](https://github.com/vercel/turborepo) | `2.11.9` | `2.11.10` | | [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) | `8.71.2` | `8.72.0` | | [@tanstack/react-query](https://github.com/TanStack/query/tree/HEAD/packages/react-query) | `5.104.4` | `5.104.5` | | [react-router](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router) | `8.4.0` | `8.5.0` | | [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) | `8.3.4` | `8.3.5` | | [@fastify/static](https://github.com/fastify/fastify-static) | `10.1.6` | `10.1.7` | | [@opentelemetry/api](https://github.com/open-telemetry/opentelemetry-js) | `1.9.1` | `1.10.0` | | [@opentelemetry/exporter-logs-otlp-http](https://github.com/open-telemetry/opentelemetry-js) | `0.223.0` | `0.300.0` | | [@opentelemetry/exporter-trace-otlp-http](https://github.com/open-telemetry/opentelemetry-js) | `0.223.0` | `0.300.0` | | [jose](https://github.com/panva/jose) | `6.2.12` | `6.2.13` | | [nodemailer](https://github.com/nodemailer/nodemailer) | `10.1.5` | `10.2.1` | | [mssql](https://github.com/tediousjs/node-mssql) | `12.7.9` | `12.7.11` | Updates `@bufbuild/buf` from 1.74.0 to 1.75.0 - [Release notes](https://github.com/bufbuild/buf/releases) - [Changelog](https://github.com/bufbuild/buf/blob/main/CHANGELOG.md) - [Commits](bufbuild/buf@v1.74.0...v1.75.0) Updates `ts-proto` from 2.17.0 to 2.18.3 - [Release notes](https://github.com/stephenh/ts-proto/releases) - [Changelog](https://github.com/stephenh/ts-proto/blob/main/CHANGELOG.md) - [Commits](stephenh/ts-proto@v2.17.0...v2.18.3) Updates `turbo` from 2.11.9 to 2.11.10 - [Release notes](https://github.com/vercel/turborepo/releases) - [Changelog](https://github.com/vercel/turborepo/blob/main/RELEASE.md) - [Commits](vercel/turborepo@v2.11.9...v2.11.10) Updates `typescript-eslint` from 8.71.2 to 8.72.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.72.0/packages/typescript-eslint) Updates `@tanstack/react-query` from 5.104.4 to 5.104.5 - [Release notes](https://github.com/TanStack/query/releases) - [Changelog](https://github.com/TanStack/query/blob/main/packages/react-query/CHANGELOG.md) - [Commits](https://github.com/TanStack/query/commits/@tanstack/react-query@5.104.5/packages/react-query) Updates `react-router` from 8.4.0 to 8.5.0 - [Release notes](https://github.com/remix-run/react-router/releases) - [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router/CHANGELOG.md) - [Commits](https://github.com/remix-run/react-router/commits/react-router@8.5.0/packages/react-router) Updates `vite` from 8.3.4 to 8.3.5 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v8.3.5/packages/vite) Updates `@fastify/static` from 10.1.6 to 10.1.7 - [Release notes](https://github.com/fastify/fastify-static/releases) - [Commits](fastify/fastify-static@v10.1.6...v10.1.7) Updates `@opentelemetry/api` from 1.9.1 to 1.10.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@v1.9.1...v1.10.0) Updates `@opentelemetry/exporter-logs-otlp-http` from 0.223.0 to 0.300.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@experimental/v0.223.0...experimental/v0.300.0) Updates `@opentelemetry/exporter-trace-otlp-http` from 0.223.0 to 0.300.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@experimental/v0.223.0...experimental/v0.300.0) Updates `jose` from 6.2.12 to 6.2.13 - [Release notes](https://github.com/panva/jose/releases) - [Changelog](https://github.com/panva/jose/blob/main/CHANGELOG.md) - [Commits](panva/jose@v6.2.12...v6.2.13) Updates `nodemailer` from 10.1.5 to 10.2.1 - [Release notes](https://github.com/nodemailer/nodemailer/releases) - [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md) - [Commits](nodemailer/nodemailer@v10.1.5...v10.2.1) Updates `mssql` from 12.7.9 to 12.7.11 - [Release notes](https://github.com/tediousjs/node-mssql/releases) - [Changelog](https://github.com/tediousjs/node-mssql/blob/master/CHANGELOG.txt) - [Commits](tediousjs/node-mssql@v12.7.9...v12.7.11) --- updated-dependencies: - dependency-name: "@bufbuild/buf" dependency-version: 1.75.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: "@fastify/static" dependency-version: 10.1.7 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: "@opentelemetry/api" dependency-version: 1.10.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: "@opentelemetry/exporter-logs-otlp-http" dependency-version: 0.300.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: "@opentelemetry/exporter-trace-otlp-http" dependency-version: 0.300.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: "@tanstack/react-query" dependency-version: 5.104.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: jose dependency-version: 6.2.13 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: mssql dependency-version: 12.7.11 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: nodemailer dependency-version: 10.2.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: react-router dependency-version: 8.5.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: ts-proto dependency-version: 2.18.2 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: turbo dependency-version: 2.11.10 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: typescript-eslint dependency-version: 8.72.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: vite dependency-version: 8.3.5 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: minor-and-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
semics-tech
marked this pull request as ready for review
October 28, 2026 06:02
semics-tech
added a commit
that referenced
this pull request
Oct 30, 2026
…mp (#157) ## Why [#151](#151) forced `@azure/msal-node` to `^7.1.0` through a pnpm override (`@azure/identity>@azure/msal-node`). The Entra path had no tests. ## Finding: no source change needed - The repo **never imports msal-node**. The only use is `acquireEntraToken` in `packages/worker/src/credentials.ts`, which calls `@azure/identity`'s `DefaultAzureCredential().getToken(scope)`. - `@azure/identity@4.14.0` declares `@azure/msal-node: ^6.0.0`, so the override takes it **outside its declared range**. This is the real risk, and it is not ours to fix in our own code. - msal-node v7.1.1 ships no changelog or migration notes, so the API was checked directly. Every msal-node symbol identity uses (`ManagedIdentityApplication`, `ConfidentialClientApplication`, `PublicClientApplication`, `AuthError`, `LogLevel`, `INativeBrokerPlugin`, `ICachePlugin`) exists in v7. Identity's `index.js` loads under v7 and `ManagedIdentityApplication` constructs. - **Not verified:** a real token fetch from Azure. There is no managed identity in the sandbox, so v7 against a live IMDS or App Service endpoint is untested. Worth one manual check on an Azure VM before 10 Nov. ## What changed Only `packages/worker/test/entra-credentials.test.ts` (15 tests, `@azure/identity` mocked). No source changes. | Area | Covered | |---|---| | Token acquisition | returns the token; appends `/.default` to a bare audience and leaves an existing one alone; no options for system-assigned identity; `clientId` goes through as `managedIdentityClientId` | | Cache and refresh | each call builds a fresh credential, so a rotated token is picked up; a failure does not poison the next call | | Error path | construction failure becomes a `CredentialError`; `null`/empty token becomes a `CredentialError` naming the scope; `getToken` rejection propagates unchanged | | `buildCallMetadata` | `authorization: Bearer …`; forwards `clientId`; missing audience fails before identity is touched; failed acquisition surfaces | ## Observation, not changed A new `DefaultAzureCredential` is built on every call, so msal's in-memory cache never survives. Correct but inefficient; caching the credential would be a small follow-up. ## CI note The earlier "Control plane image builds" failure was infra, not the repo. The image built fine and the job failed at the end exporting the GitHub Actions cache (`error writing layer blob: not_found`). The same check passes on [#155](#155). Main was merged into this branch (rebase would need a force-push) so CI reruns on a fresh commit. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- _Draft opened by Oli's repos agent._ Co-authored-by: Agent Harness <agent@SEMICSs-Mac-mini.local> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #152. Same 14 dependency updates, plus one commit regenerating
packages/protocol/src/genfor ts-proto 2.18.3, which fixes the failing "Check generated protobuf is current" step.Update 30 Oct: merged main (incl. #157) into the branch, no rebase. Conflicts were in the root
package.json,packages/dashboard/package.jsonandpnpm-lock.yaml. I kept the higher version of each (vitest ^4.1.11, vite ^8.3.5, typescript-eslint ^8.72.0), bumped@vitest/coverage-v8to ^4.1.11 to match, and regenerated the lockfile withpnpm install --lockfile-only. ts-proto stays at 2.18.3, so the generated protobuf is unchanged.Local: typecheck passes and lint has 0 errors (1 existing warning).
proto:checkcouldn't run in my sandbox because tsx can't open its IPC socket (EPERM), so CI is the judge.🤖 Generated with Claude Code