Skip to content

build(deps): override dompurify and msal-node past their advisories - #149

Closed
semics-tech wants to merge 1 commit into
mainfrom
agent/audit-dompurify
Closed

semics-tech wants to merge 1 commit into
mainfrom
agent/audit-dompurify

Conversation

@semics-tech

Copy link
Copy Markdown
Owner

main fails Dependency audit (pnpm audit --audit-level high) independently of #148: the lockfile on main resolves dompurify@3.4.15 and @azure/msal-node@6.0.1, both now flagged. #148 only fails because it inherits that.

Advisories cleared

  • critical: DOMPurify SAFE_FOR_TEMPLATES bypass, GHSA-cg2g-xh64-v4q7 (dompurify, via monaco-editor; fixed >=3.4.17)
  • high: DOMPurify IN_PLACE hook, GHSA-mrv2-3pqr-j5jr (same path)
  • high: MSAL Node auth code flow parameter disclosure, GHSA-xcx6-jx8p-x3h5 (@azure/identity > @azure/msal-node; fixed >=7.1.0)

Change

pnpm.overrides: dompurify ^3.4.17, @azure/msal-node ^7.1.0. Needed because monaco-editor pins dompurify exactly and @azure/identity 4.14.0 (latest) depends on msal-node ^6. No audit ignores added, no workflow changes. Remove the overrides once upstream releases carry the fixed ranges.

Verified locally

  • pnpm audit --audit-level high exits 0 (remaining high is the existing documented node-forge ignore; moderate/low untouched).
  • lint and typecheck pass. Worker bundle builds and --rsagent-selftest runs with the .mjs alone.
  • Unit tests: the same 26 worker failures occur with and without this change (no Postgres or file-mode support in my sandbox), so rely on CI for those.

Worth a look: msal-node moves a major (6 to 7) under @azure/identity, which is bundled into the worker. Only the Azure credential path (AAD auth to SQL) would exercise it; the selftest does not.

🤖 Generated with Claude Code


Draft opened by Oli's repos agent.

monaco-editor pins dompurify 3.4.15 and @azure/identity 4.14.0 depends on
@azure/msal-node ^6, so neither can be cleared by a direct bump. Both
overrides can go once monaco-editor and @azure/identity release with the
fixed ranges.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@semics-tech

Copy link
Copy Markdown
Owner Author

Closed by Oli's harness: Superseded by #151 (overrides scoped to the parents; no parent release fixes either advisory).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant